Missing default case in switch statement CXX-W1164
Anti-pattern
Minor
a year ago
—
a year old
Missing default case in switch statement
27 int size;
28 char **cmd1 = (char **)malloc(MAX_CMD);
29 char **cmd2 = (char **)malloc(MAX_CMD);
30 switch ((int)ctx->last_comm_op) 31 {
32 case LM_AND:
33 split_string_subs(ctx->last_comm, "&&", array_string);Missing default case in switch statement
146 char **cmd1 = (char **)malloc(MAX_CMD);
147 char **cmd2 = (char **)malloc(MAX_CMD);
148
149 switch ((int)ctx->last_comm_op)150 {
151 case LM_AND:
152 split_string_subs(line, "&&", array_string);
Description
Default case provides switch statements with fallback, and in general is a good to have. Hence consider adding default case to switch.
Bad practice
int x = 10;
switch x {
case 1: {
printf("You chose 1.");
break;
}
case 2: {
printf("You chose 2.");
break;
}
}
Recommended
int x = 10;
switch x {
case 1: {
printf("You chose 1.");
break;
}
case 2: {
printf("You chose 2.");
break;
}
default: {
printf("Invalid choice!");
break;
}
}