Class methods should utilize
this JS-0105
Anti-pattern
Minor
3 years ago
—
3 years old
Expected 'this' to be used by class method 'render'
9 return { ...initialProps };
10 }
11
12 render() {13 return (14 <Html data-theme="light" lang="en-us">15 <Head>16 <meta charSet="UTF-8" />17 <meta18 content="Donations for Margarita Humanitarian Foundation"19 name="description"20 />21 <meta content="donate" name="keywords" />22 <meta23 content="Donations for Margarita Humanitarian Foundation"24 property="og:site_name"25 />26 <meta27 content="Help a family through Margarita Humanitarian Foundation"28 property="og:title"29 />30 <meta content="website" property="og:type" />31 <meta32 content="https://helpafamily.margaritahumanitarian.org"33 property="og:url"34 />3536 <meta content="/branding/social-share.jpg" property="og:image" />3738 {/* Twitter card tags */}39 <meta40 content="Donations for Margarita Humanitarian Foundation"41 name="twitter:card"42 />43 <meta44 content="Donate to Margarita Humanitarian Foundation"45 name="twitter:title"46 />47 <meta48 content="Donations for Margarita Humanitarian Foundation"49 name="twitter:description"50 />51 <meta content="/branding/social-share.png" name="twitter:image" />52 <meta content="@margaritahforg" name="twitter:site" />53 <meta content="@margaritahforg" name="twitter:creator" />5455 {/* Favicon */}5657 <link href="/images/favicon.ico" rel="icon" />5859 {/* Windows Tile colour */}60 <meta content="#100030" name="msapplication-TileColor" />61 <meta content="#100030" name="theme-color" />6263 {/* Roboto Font */}64 <link65 as="font"66 crossOrigin=""67 href="/fonts/Source_Sans_Pro/SourceSansPro-Regular.ttf"68 rel="preload"69 />70 <link71 as="font"72 crossOrigin=""73 href="/fonts/Source_Sans_Pro/SourceSansPro-Bold.ttf"74 rel="preload"75 />76 </Head>77 <body>78 <Main />79 <NextScript />80 <div id="modal-root" />81 </body>82 </Html>83 );84 }85}
86
87export default MyDocument;
Description
If a class method does not use this, it can sometimes be made into a static function. If you do convert the method into a static function, instances of the class that call that particular method have to be converted to a static call as well (MyClass.callStaticMethod())
Bad Practice
class Person {
sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
const person = new Person();
person.sayHi();
Recommended
class Person {
static sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
Person.sayHi();