Found multiple import of the same path JS-R1000
Style
Minor
5 months ago
—
5 months old
'/code/app/javascript/mastodon/actions/notifications.js' imported multiple times
3import ColumnSettings from '../components/column_settings';
4import { changeSetting } from '../../../actions/settings';
5import { setFilter } from '../../../actions/notifications';
6import { clearNotifications, requestBrowserPermission } from '../../../actions/notifications'; 7import { changeAlerts as changePushNotifications } from '../../../actions/push_notifications';
8import { openModal } from '../../../actions/modal';
9import { showAlert } from '../../../actions/alerts';'/code/app/javascript/mastodon/actions/notifications.js' imported multiple times
2import { defineMessages, injectIntl } from 'react-intl';
3import ColumnSettings from '../components/column_settings';
4import { changeSetting } from '../../../actions/settings';
5import { setFilter } from '../../../actions/notifications'; 6import { clearNotifications, requestBrowserPermission } from '../../../actions/notifications';
7import { changeAlerts as changePushNotifications } from '../../../actions/push_notifications';
8import { openModal } from '../../../actions/modal';'/code/app/javascript/mastodon/actions/compose.js' imported multiple times
1import { connect } from 'react-redux';
2import Upload from '../components/upload';
3import { undoUploadCompose, initMediaEditModal } from '../../../actions/compose';
4import { submitCompose } from '../../../actions/compose'; 5
6const mapStateToProps = (state, { id }) => ({
7 media: state.getIn(['compose', 'media_attachments']).find(item => item.get('id') === id),'/code/app/javascript/mastodon/actions/compose.js' imported multiple times
1import { connect } from 'react-redux';
2import Upload from '../components/upload';
3import { undoUploadCompose, initMediaEditModal } from '../../../actions/compose'; 4import { submitCompose } from '../../../actions/compose';
5
6const mapStateToProps = (state, { id }) => ({'/code/app/javascript/mastodon/actions/compose.js' imported multiple times
5 clearComposeSuggestions,
6 fetchComposeSuggestions,
7 selectComposeSuggestion,
8} from '../../../actions/compose'; 9
10const mapStateToProps = state => ({
11 suggestions: state.getIn(['compose', 'suggestions']),
Description
It is always recommended to group all imports of a single path or source in a single import declaration. These usually happen in a codebase when multiple developers are working on the same codebase. It helps improving code refactoring and code readability as well.
Bad Practice
// <!-- index.js -->
import calc from './calc.js'
import { add } from './calc.js'
console.log(add(1, 2))
Recommended
// <!-- index.js -->
import calc, { add } from './calc.js'
console.log(add(1, 2))