Consider changing "not 0.0 <= eps" to "0.0 > eps"
198 ):
199 if not 0.0 <= lr:
200 raise ValueError('Invalid learning rate: {}'.format(lr))
201 if not 0.0 <= eps:202 raise ValueError('Invalid epsilon value: {}'.format(eps))
203 if not 0.0 <= betas[0] < 1.0:
204 raise ValueError(
Consider changing "not 0.0 <= weight_decay" to "0.0 > weight_decay"
208 raise ValueError(
209 'Invalid beta parameter at index 1: {}'.format(betas[1])
210 )
211 if not 0.0 <= weight_decay:212 raise ValueError(
213 'Invalid weight_decay value: {}'.format(weight_decay)
214 )
Consider changing "not 0.0 <= weight_decay" to "0.0 > weight_decay"
399 raise ValueError(
400 'Invalid beta parameter at index 1: {}'.format(betas[1])
401 )
402 if not 0.0 <= weight_decay:403 raise ValueError(
404 'Invalid weight_decay value: {}'.format(weight_decay)
405 )
Consider changing "not 0.0 <= lr" to "0.0 > lr"
196 amsgrad=False,
197 adamd_bias_correction: bool = False,
198 ):
199 if not 0.0 <= lr:200 raise ValueError('Invalid learning rate: {}'.format(lr))
201 if not 0.0 <= eps:
202 raise ValueError('Invalid epsilon value: {}'.format(eps))
Consider changing "not 0.0 <= eps" to "0.0 > eps"
389 ):
390 if not 0.0 <= lr:
391 raise ValueError('Invalid learning rate: {}'.format(lr))
392 if not 0.0 <= eps:393 raise ValueError('Invalid epsilon value: {}'.format(eps))
394 if not 0.0 <= betas[0] < 1.0:
395 raise ValueError(
Consider changing "not 0.0 <= lr" to "0.0 > lr"
387 amsgrad=False,
388 adamd_bias_correction: bool = False,
389 ):
390 if not 0.0 <= lr:391 raise ValueError('Invalid learning rate: {}'.format(lr))
392 if not 0.0 <= eps:
393 raise ValueError('Invalid epsilon value: {}'.format(eps))
Description
The boolean expression contains an unneeded negation and can be re-written without using the not
statement.
Bad practice
def categorize_number(num):
if not num % 2 == 0:
print("The number is odd.")
else:
print("The number is even.")
Here, the condition not num % 2 == 0
contains an unneeded not
and can be changed into num % 2 != 0
.
A clearer and more straightforward approach would look like this:
Recommended
def categorize_number(num):
if num % 2 != 0:
print("The number is odd.")
else:
print("The number is even.")