Protected member accessed from outside the class PYL-W0212
Bug risk
Minor
3 years ago
—
3 years old
Access to a protected member _values of a client class
144 grad_sum_sq_masked.add_(grad_sq, alpha=lamb)
145
146 rms_masked_vals = (
147 grad_sum_sq_masked._values().pow_(1 / 3).add_(eps)148 )
149
150 s.add_(grad, alpha=lamb)Access to a protected member _values of a client class
135 grad_sum_sq_masked._values().pow(1 / 3).add_(eps)
136 )
137 x0_masked_vals = p_masked._values().addcdiv(
138 s_masked._values(), rms_masked_vals, value=1139 )
140
141 # Dense + sparse opAccess to a protected member _values of a client class
134 rms_masked_vals = (
135 grad_sum_sq_masked._values().pow(1 / 3).add_(eps)
136 )
137 x0_masked_vals = p_masked._values().addcdiv(138 s_masked._values(), rms_masked_vals, value=1
139 )
140Access to a protected member _values of a client class
132
133 # Compute x_0 from other known quantities
134 rms_masked_vals = (
135 grad_sum_sq_masked._values().pow(1 / 3).add_(eps)136 )
137 x0_masked_vals = p_masked._values().addcdiv(
138 s_masked._values(), rms_masked_vals, value=1Access to a protected member _values of a client class
155 s_masked._values(), rms_masked_vals, value=-1
156 )
157 # Copy updated masked p to dense p using an add operation
158 p_masked._values().add_(p_kp1_masked_vals, alpha=-1)159 p.data.add_(p_masked, alpha=-1)
160 else:
161 if momentum == 0:
Description
Accessing a protected member (a member prefixed with _) of a class from outside that class is not recommended, since the creator of that class did not intend this member to be exposed. If accesing this attribute outside of the class is absolutely needed, refactor it such that it becomes part of the public interface of the class.
Bad practice
class Rectangle(object):
def __init__(self, height, width):
self._height = height
self._width = width
r = Rectangle(4, 8)
area = r._height * r._width
Preferred:
class Rectangle(object):
def __init__(self, height, width):
self._height = height
self._width = width
def area():
return self._height * self._width
r = Rectangle(4, 8)
area = r.area()