Unnecessary lambda expression PYL-W0108
Anti-pattern
Major
2 months ago
—
4 years old
Lambda may not be necessary
320 def map_models(x):
321 return x[0], dict(map(lambda r: map_model_relations(r), x[1].items()))
322
323 return dict(map(lambda x: map_models(x), relationships.items())) 324
325 def get_model_columns_by_clean_name(self, MappedBase, mapper):
326 table = mapper.tables[0]Lambda may not be necessary
318 return clean_name(x[0]), x[1]
319
320 def map_models(x):
321 return x[0], dict(map(lambda r: map_model_relations(r), x[1].items())) 322
323 return dict(map(lambda x: map_models(x), relationships.items()))
324Lambda may not be necessary
870 data_selections = self.get_selections(info, ['data']) or []
871 data_names = list(map(lambda x: x.name.value, data_selections))
872 model_attrs = dict(map(lambda x: [clean_name(x), getattr(Model, x)], dir(Model)))
873 only_columns = list(filter(lambda x: x is not None, map(lambda x: model_attrs.get(x), field_names))) \ 874 if len(field_names) and 'allAttrs' not in data_names else None
875
876 queryset = self.get_queryset(request, Model, only_columns)Lambda may not be necessary
197 return row
198
199 try:
200 instance = list(map(lambda x: map_item(x), queryset))201 except SQLAlchemyError:
202 queryset.session.rollback()
203 raiseLambda may not be necessary
107
108 def to_representation(self, value):
109 if self.many:
110 return list(map(lambda x: self.to_representation_item(x), value or []))111 else:
112 return self.to_representation_item(value)
113
Description
A lambda that calls a function without modifying any of its parameters is unnecessary. Python functions are first-class objects and can be passed around in the same way as the resulting lambda. It is recommended to remove the lambda and use the function directly.
It is preferred to use the function hash directly as the lambda function calls the same function without any modifications.
Another reason to avoid the lambda function here is that it makes debugging difficult.
Lambdas show as <lambda> in tracebacks, where functions will display the function’s name.
Bad practice
items = [1, 2, 3]
hashify = lambda x: hash(x)
hashed_items = map(hashify, items)
Recommended
items = [1, 2, 3]
# pass the builtin `hash` instead of the wrapper `hashify`
hashed_items = map(hash, items)