Consider removing the commented out code block PY-W0069
Anti-pattern
Major
8 months ago
—
2 years old
Consider removing the commented out code block
170 # x_serializers = list(filter(lambda x: x.field_name == x_column, model_serializer.fields))
171 # x_serializer = x_serializers[0]
172
173 # y_serializers = list(filter(lambda x: x.field_name == y_column, model_serializer.fields))174 # y_serializer = y_serializers[0]
175
176 filter_instance = ModelGroupFilter()Consider removing the commented out code block
167
168 model_serializer = self.get_serializer(request)
169
170 # x_serializers = list(filter(lambda x: x.field_name == x_column, model_serializer.fields))171 # x_serializer = x_serializers[0]
172
173 # y_serializers = list(filter(lambda x: x.field_name == y_column, model_serializer.fields))Consider removing the commented out code block
85 def run_validation(self, value):
86 if value is empty:
87 if self.required:
88 # raise ValidationError('Field is required') 89 self.error('required')
90 else:
91 return NoneConsider removing the commented out code block
70 data_type = get_column_data_type(column)
71 kwargs = {'context': self.context, 'serializer': self}
72
73 # if column.primary_key and column.autoincrement: 74 # kwargs['read_only'] = True
75 if column.autoincrement or column.default or column.server_default or column.nullable:
76 kwargs['required'] = FalseConsider removing the commented out code block
223 return result
224
225
226# def map_relation(relation):227# field = None
228#
229# if relation.direction == ONETOMANY:
Description
It is recommended to remove any commented code in your codebase.
Bad practice
for item in sequence:
# print(item)
do_something(item)
# def old_function():
# '''Older implementation that has been replaced'''
# data = get_data()
# api.post(data)
Recommended
for item in sequence:
do_something(item)