Empty block of code found PHP-W1085
Anti-pattern
Major
3 months ago
—
3 months old
Empty
if block found366 if ($i){ $color = '#FFFFFF'; $i = False; }
367 else{ $color = '#EEEEEE'; $i = True; }
368
369 if ($k == 'precision' || $k == 'ipm' || $k == 'nutrient'){370 }
371 echo sprintf("<tr style='background: ${color}'><th>%s</th>
372 %s %s %sEmpty
if block found 1<?php
2if (isset($_REQUEST["farmcode"])){ 3
4}
5Empty
if block found 84curl_setopt( $ch, CURLOPT_HTTPHEADER, $request_headers ); // (re-)send headers
85curl_setopt( $ch, CURLOPT_RETURNTRANSFER, true ); // return response
86curl_setopt( $ch, CURLOPT_HEADER, true ); // enabled response headers
87if ($request_method == 'GET'){ 88
89}
90elseif ($request_method == 'POST'){
Description
An empty block is considered as dead code as it doesn't do anything. The issue is raised when loops, conditionals, or other statements contains empty body which implies some piece of code is missing.
It is advised to remove the empty block since keeping them in the codebase wastes computation time and memory.
// Bad practice
foreach ($users as $user) {
}
if ($isUserActive) {
}
// Recommended
foreach ($users as $user) {
echo $user->getName();
}
if ($isUserActive) {
echo $user->getName();
}