Unused constructor parameter PHP-W1037
Anti-pattern
Major
3 months ago
—
3 months old
Constructor of class MyView has an unused parameter $template_dir
10 */
11class MyView {
12 protected $vars = array();
13 public function __construct($template_dir = null) {14 $this->template_dir = dirname(__FILE__).'/templates/';
15 }
16 public function render($template_file) {
Description
The constructor signature contains one or more unused parameters. Since these are nowhere used in the class, it can be safely removed.
Bad Practice
class UnusedParam
{
public function __construct($unusedParameter)
{}
}
Recommended:
class UnusedParam
{
public function __construct()
{}
}