Expected 'this' to be used by class method 'appendPathToUrlWithEndingSlash'
29 return secret.value;
30 }
31
32 protected appendPathToUrlWithEndingSlash(basename: string, path: string) { 33 if (basename.endsWith("/")) {
34 return `${basename}${path}`;
35 }
Description
If a class method does not use this, it can sometimes be made into a static function. If you do convert the method into a static function, instances of the class that call that particular method have to be converted to a static call as well (MyClass.callStaticMethod())
Bad Practice
class Person {
sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
const person = new Person();
person.sayHi();
Recommended
class Person {
static sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
Person.sayHi();