PTC-W0046 @ f5c90b3 • heitorpolidoro / bartholomew-smith

Run summary

2 months ago

bb173de..f5c90b3

3 mins 13 s

Unit test class with no tests PTC-W0046

Anti-pattern

Major

1 occurrence in this check

Unittest class ManagerCheckRunTestCase contains no test methods

tests/managers/pull_request_manager/__init__.py

 13__tracebackhide__ = True
 14
 15
 16class ManagerCheckRunTestCase(TestCase): 17    client = app.test_client()
 18
 19    def teardown_method(self, method):

Description

Test methods should always start with the test. If there are no such methods, the class overriding unittest.TestCase won't run any test.

Not preferred:

import unittest

def Tests(unittest.TestCase):
    def my_test(self, arg1, arg2):
        self.assertEquals(arg1, arg2)

Preferred:

import unittest

def Tests(unittest.TestCase):
    def test_something(self, arg1, arg2):
        self.assertEquals(arg1, arg2)