this value of numerator is never used
385 step, changed := GetCommonStep(pair)
386 if changed || len(numerator.Values) != len(denominator.Values) {
387 alignedSeries := ScaleToCommonStep(types.CopyMetricDataSlice(pair), step)
388 numerator = alignedSeries[0]389 denominator = alignedSeries[1]
390
391 return alignedSeries[0], alignedSeries[1]
this value of denominator is never used
386 if changed || len(numerator.Values) != len(denominator.Values) {
387 alignedSeries := ScaleToCommonStep(types.CopyMetricDataSlice(pair), step)
388 numerator = alignedSeries[0]
389 denominator = alignedSeries[1]390
391 return alignedSeries[0], alignedSeries[1]
392 }
this value of err is never used
47 refetch := false
48 switch e.Arg(1).Type() {
49 case parser.EtConst:
50 windowPoints, err = e.GetIntArg(1) 51 argstr = strconv.Itoa(windowPoints)
52 if windowPoints < 0 {
53 // we only care about the absolute value
Description
Value has been assigned to a variable, but it is being overwritten before being read. In most cases, this could be a forgotten error check or dead code.
Bad practice
err := Op1()
// error value assigned to "err" by "Op1" is replaced with
// error value assigned by "Op2" before even being read even
// once
err = Op2()
if err != nil {
return err
}
Recommended
// Ignore the error value returned by "Op1"
Op1()
err := Op2()
if err != nil {
return err
}
err := Op1()
// Read the error value assigned to "err" by "Op1"
if err != nil {
return err
}
err = Op2()
if err != nil {
return err
}