Consider decorating method with
@staticmethod PYL-R0201
Performance
Major
4 months ago
—
7 months old
Method doesn't use the class instance and could be converted into a static method
149 except (IOError, ValueError) as e:
150 log.warning("Error writing to cache file: %s", e)
151
152 def is_instance(self):153 """Check if project holder is valid instance."""
154 return False
155Method doesn't use the class instance and could be converted into a static method
40 self.hostname = PypiRepoSession.DEFAULT_HOSTNAME
41 self.project = self.get_project()
42
43 def release_download_url(self, release, shorter=False):44 """Get release download URL."""
45 for f in release["files"]:
46 if f["packagetype"] == "sdist":
Description
The method doesn't use its bound instance. Decorate this method with @staticmethod decorator, so that Python does not have to instantiate a bound method for every instance of this class thereby saving memory and computation. Read more about staticmethods here.