Method is empty and effectively does nothing CS-R1093
Anti-pattern
Critical
a month ago
—
a month old
Method is empty
501 /// If installing from the web and using .NetCoreApp3.1, the stream download is unable to be cancelled due to no support for CopyToAsync overload with a cancellation token. <br/>
502 /// If cancellation is requested during the download, it will throw prior to the process that triggers the update being started.
503 /// </remarks>
504 private void UpdateAsyncRemarks()505 {506 }507#else
508 private void UpdateAsyncRemarks() { }
509#endif
Description
A method that neither has any attributes nor participates in inheritance effectively does nothing and is redundant. Since such methods do not contribute anything of value to the codebase, consider removing such empty methods. Note that methods with user comments or pragmas are excluded from this issue.
Bad Practice
class C
{
public void DoThis()
{
}
}
Recommended
class C
{
public void DoThis(int i)
{
Console.WriteLine(i);
}
}