Consider rewriting
using statement as using declaration CS-R1050
Anti-pattern
Major
a month ago
—
a month old
Using block can be simplified347
348 if (_From == InstallFrom.Unc)
349 {
350 using (var stream = File.OpenRead(Path.Combine($"{_PublishPath}", $"{_CurrentAppName}.application")))351 {352 return await ReadServerManifest(stream, token);353 }354 }
355
356 throw new ClickOnceDeploymentException("No network install was set");Using block can be simplified338 {
339 using (var client = new HttpClient { BaseAddress = new Uri(_PublishPath) })
340 {
341 using (var stream = await client.GetStreamAsync($"{_CurrentAppName}.application"))342 {343 return await ReadServerManifest(stream, token);344 }345 }
346 }
347Using block can be simplified336 {
337 if (_From == InstallFrom.Web)
338 {
339 using (var client = new HttpClient { BaseAddress = new Uri(_PublishPath) })340 {341 using (var stream = await client.GetStreamAsync($"{_CurrentAppName}.application"))342 {343 return await ReadServerManifest(stream, token);344 }345 }346 }
347
348 if (_From == InstallFrom.Unc)
Description
The using statement defines a scope at the end of which an object will be disposed. The downside is that this increases the indentation level of your code. However, with C# 8.0, you can use the new using declaration that no longer requires you to explicitly mention the braces. Although this reduces your code's indentation and nesting, the downside of this approach, however, is that the resource's lifetime may increase.
Bad Practice
using (var resource = new SomeResource())
{
// `resource` is `dispose`d off as soon as it exits this scope.
}
Recommended
// `resource` is now confined to the parent scope.
// This may increase its lifetime.
using var resource = new SomeResource();