Method receiver 'e' is not referenced in method's body, consider removing it
11
12type VaultLoginTimeout struct{}
13
14func (e VaultLoginTimeout) Error() string { 15 return "timed out to login to vault"
16}
17Method receiver 'manager' is not referenced in method's body, consider removing it
185 return lc.credhub, nil
186}
187
188func (manager CredHubManager) Close(logger lager.Logger) {189 // TODO - to implement
190}
Description
Methods with unused receivers can be a symptom of unfinished refactoring or a bug. To keep the same method signature, omit the receiver name or '_' as it is unused.
Bad practice
func (f *Unix) Name() string {
return "unix"
}
func (_ *Unix) Name() string {
return "unix"
}
Recommended
func (*Unix) Name() string {
return "unix"
}