Void operators found JS-0098
Anti-pattern
Minor
a month ago
—
3 months old
Expected 'undefined' and instead saw 'void'
4 var _a;
5 clickEvent.preventDefault();
6 const panelBlockElements = (_a = clickEvent.currentTarget
7 .closest('.panel')) === null || _a === void 0 ? void 0 : _a.querySelectorAll('.panel-block'); 8 if (panelBlockElements !== undefined) {
9 for (const panelBlockElement of panelBlockElements) {
10 panelBlockElement.classList.toggle('is-hidden');Expected 'undefined' and instead saw 'void'
4 var _a;
5 clickEvent.preventDefault();
6 const panelBlockElements = (_a = clickEvent.currentTarget
7 .closest('.panel')) === null || _a === void 0 ? void 0 : _a.querySelectorAll('.panel-block'); 8 if (panelBlockElements !== undefined) {
9 for (const panelBlockElement of panelBlockElements) {
10 panelBlockElement.classList.toggle('is-hidden');Expected 'undefined' and instead saw 'void'
133 paginationElement.append(nextElement);
134 }
135 (_h = searchResultsElement
136 .querySelector('.level')) === null || _h === void 0 ? void 0 : _h.append(paginationElement);137 }
138 });
139 }Expected 'undefined' and instead saw 'void'
133 paginationElement.append(nextElement);
134 }
135 (_h = searchResultsElement
136 .querySelector('.level')) === null || _h === void 0 ? void 0 : _h.append(paginationElement);137 }
138 });
139 }Expected 'undefined' and instead saw 'void'
88 </td>`;
89 tbodyElement.append(trElement);
90 }
91 (_g = searchResultsElement.querySelector('table')) === null || _g === void 0 ? void 0 : _g.append(tbodyElement); 92 searchResultsElement.insertAdjacentHTML('beforeend', `<div class="level is-block-print">
93 <div class="level-left has-text-weight-bold">
94 Displaying
Description
A return; statement with nothing after it is redundant, and has no effect on the runtime behavior of a function.
This can be confusing, so it's better to disallow these redundant statements.
Bad Practice
function foo() { return; }
function foo() {
doSomething();
return;
}
function foo() {
if (condition) {
bar();
return;
} else {
baz();
}
}
function foo() {
switch (bar) {
case 1:
doSomething();
default:
doSomethingElse();
return;
}
}
Recommended
function foo() { return 5; }
function foo() {
return doSomething();
}
function foo() {
if (condition) {
bar();
return;
} else {
baz();
}
qux();
}
function foo() {
switch (bar) {
case 1:
doSomething();
return;
default:
doSomethingElse();
}
}
function foo() {
for (const foo of bar) {
return;
}
}