Found empty block statements JS-0009
Anti-pattern
Minor
3 months ago
—
3 months old
Empty block statement
16 try {
17 httpServer.close();
18 }
19 catch {20 }21 });
22 it('Ensure server starts on port ' + portNumber.toString(), () => {
23 assert.ok(serverStarted);
Description
Empty block statements, while not technically errors, usually occur due to refactoring that wasn't completed. They can mislead the reader.
If you still want to keep an empty block, add a comment saying empty inside the block.
Bad Practice
if (someCheck) {}
while (someCheck) {}
try {
doSomething();
} catch(err) {
} finally {
}
Recommended
if (someCheck) {
// empty
}
while (someCheck) {
/* empty */
}
try {
doSomething();
} catch (err) {
// continue regardless of error
}
try {
doSomething();
} finally {
/* continue regardless of error */
}