Detected the use of variables before they are defined JS-0357
Anti-pattern
Major
11 days ago
—
11 days old
'setIsOpenDeleteTemplateModal' was used before it was defined
87
88 const handleDeleteTemplateButton = async (template: TableData) => {
89 setSelectedTemplate(template);
90 setIsOpenDeleteTemplateModal(!isOpenDeleteTemplateModal); 91 };
92
93 const rowActions = ['isOpenDeleteTemplateModal' was used before it was defined
87
88 const handleDeleteTemplateButton = async (template: TableData) => {
89 setSelectedTemplate(template);
90 setIsOpenDeleteTemplateModal(!isOpenDeleteTemplateModal); 91 };
92
93 const rowActions = ['setIsOpenEditTemplateModal' was used before it was defined
82 _id: template._id,
83 name: template.name,
84 }));
85 setIsOpenEditTemplateModal(true); 86 };
87
88 const handleDeleteTemplateButton = async (template: TableData) => {'setTableData' was used before it was defined
46 try {
47 const data = await getTemplates();
48 setTemplates(data.datas);
49 setTableData(data.datas); 50 setLoading(false);
51 } catch (err) {
52 setError('Error fetching company');'isOpenDeleteCompanyModal' was used before it was defined
95
96 const handleDeleteCompanyButton = (company: TableData) => {
97 setSelectedCompany(company);
98 setIsOpenDeleteCompanyModal(!isOpenDeleteCompanyModal); 99 };
100
101 const rowActions = [
Description
Variables, functions and types should always be used after they've been defined. This issue will flag any code snippets that use variables or types before definition.
Sometimes, the code will run just fine even when the variable is declared after use. Consider the following example:
const ram: Resource = { type: "memory", limit: 1024 ** 3 }
type Resource = {
type: string;
limit: number;
}
Here, Resource is used in the annotation before it has been defined.
Similarly, it is possible to hoist function declarations and variables declared with the var keyword:
const four = twice(2);
function twice(n: number) {
return n * 2;
}
However, it makes the code harder to follow when variables or types are declared after being used.
Bad Practice
const knight: Radiant = {
order: "SurgeBinder"
strength: 30
}
interface Radiant {
order: string;
strength: number;
}
Recommended
interface Radiant {
order: string;
strength: number;
}
const knight: Radiant = {
order: "SurgeBinder"
strength: 30
}