Require template literals instead of string concatenation JS-0246
Anti-pattern
Minor
11 days ago
—
11 days old
Unexpected string concatenation
259 if (cwe !== 'N/A') {
260 const cweTranslated = GetCWENameByLanguage(detail.locale, cwe);
261 setCweRecommendation(
262 responseCWE.result[0].label + ': ' + cweTranslated,263 );
264 setCweButtonChanged(true);
265 } else {Unexpected string concatenation
218 if (cwe !== 'N/A') {
219 const cweTranslated = GetCWENameByLanguage(detail.locale, cwe);
220 setCweRecommendation(
221 responseCWE.result[0].label + ': ' + cweTranslated,222 );
223 setCweButtonChanged(true);
224 } else {Unexpected string concatenation
277 title={t('msg.confirmSuppression')}
278 >
279 <p>
280 {t('template') +281 ` <<${selectedTemplate?.name}>> ` +282 t('msg.deleteNotice') +283 '!'}284 </p>
285 </Modal>
286 </>Unexpected string concatenation
300 title={t('msg.confirmSuppression')}
301 >
302 <p>
303 {t('company') +304 ` <<${selectedCompany?.name}>> ` +305 t('msg.deleteNotice') +306 '!'}307 </p>
308 </Modal>
309 </>Unexpected string concatenation
515 title={t('msg.confirmSuppression')}
516 >
517 <p>
518 {t('client') +519 ` <<${selectedClient?.firstname} ` +520 `${selectedClient?.lastname}>> ` +521 t('msg.deleteNotice') +522 '!'}523 </p>
524 </Modal>
525 </>
Description
In ES2015 (ES6), we can use template literals instead of string concatenation.
var str = `Hello, ${name}!`;
Bad Practice
var str = "Hello, " + name + "!";
var str = "Time: " + (12 * 60 * 60 * 1000);
Recommended
var str = "Hello World!";
var str = `Hello, ${name}!`;
var str = `Time: ${12 * 60 * 60 * 1000}`;
var str = "Hello, " + "World!";