Use
const declarations for variables that are never reassigned JS-0242
Anti-pattern
Minor
11 days ago
—
11 days old
'fileStat' is never reassigned. Use 'const' instead
8
9var files = fs.readdirSync(routesFolder);
10files.forEach(file => {
11 let fileStat = fs.statSync(routesFolder + '/' + file).isDirectory();12 if (!fileStat) {
13 endpointsFiles.push(routesFolder + '/' + file);
14 }'dictionary' is never reassigned. Use 'const' instead
8
9function translate(message, locale = gLocale) {
10 try {
11 let dictionary = JSON.parse(fs.readFileSync(`${__dirname}/${locale}.json`));12 return dictionary[message] || message;
13 } catch (error) {
14 return message;'totpUrl' is never reassigned. Use 'const' instead
316 newConfig.secret = secret;
317
318 let totp = new OTPAuth.TOTP(newConfig);
319 let totpUrl = totp.toString();320
321 QRCode.toDataURL(totpUrl, function (err, url) {
322 resolve({'totp' is never reassigned. Use 'const' instead
315 }).base32;
316 newConfig.secret = secret;
317
318 let totp = new OTPAuth.TOTP(newConfig);319 let totpUrl = totp.toString();
320
321 QRCode.toDataURL(totpUrl, function (err, url) {'newConfig' is never reassigned. Use 'const' instead
308// gen totp QRCode url
309UserSchema.statics.getTotpQrcode = function (username) {
310 return new Promise((resolve, reject) => {
311 let newConfig = totpConfig;312 newConfig.label = username;
313 const secret = new OTPAuth.Secret({
314 size: 10,
Description
Variables that are never re-assigned a new value after their initial declaration should be declared with the const keyword.
This prevents the programmer from erroneously re-assigning to a read-only variable, and informs those reading the code that a variable is a constant value.
Bad Practice
let pi = Math.PI
for (let x of xs) {
use(x);
}
let { a, b } = object;
use(a, b);
Recommended
const pi = Math.PI
for (const x of xs) {
use(x);
}
const { a, b } = object;
use(a, b);