Initialization in variable declarations against recommended approach JS-0119
Anti-pattern
Minor
11 days ago
—
11 days old
Variable '$t' should be initialized on declaration
13var Settings = require('mongoose').model('Settings');
14var CVSS31 = require('./cvsscalc31.js');
15var translate = require('../translate');
16var $t; 17
18// Generate document with docxtemplater
19async function generateDoc(audit) {Variable 'modifiedExploitability' should be initialized on declaration
420 var miss; /* Modified Impact Sub-Score */
421 var modifiedImpact;
422 var envScore;
423 var modifiedExploitability; 424
425 miss = Math.min(
426 1 -Variable 'envScore' should be initialized on declaration
419
420 var miss; /* Modified Impact Sub-Score */
421 var modifiedImpact;
422 var envScore; 423 var modifiedExploitability;
424
425 miss = Math.min(Variable 'modifiedImpact' should be initialized on declaration
418 // given in the Environmental metrics group.
419
420 var miss; /* Modified Impact Sub-Score */
421 var modifiedImpact; 422 var envScore;
423 var modifiedExploitability;
424Variable 'miss' should be initialized on declaration
417 // Environmental metrics group in place of the values specified in the Base Score, and any additional weightings
418 // given in the Environmental metrics group.
419
420 var miss; /* Modified Impact Sub-Score */ 421 var modifiedImpact;
422 var envScore;
423 var modifiedExploitability;
Description
In JavaScript, variables can be assigned during declaration, or at any point afterwards using an assignment statement. For example, in the following code, foo is initialized during declaration, while bar is initialized later.
var foo = 1;
var bar;
if (foo) {
bar = 1;
} else {
bar = 2;
}
Bad Practice
function foo() {
var bar;
let baz;
}
Recommended
function foo() {
var bar = 1;
let baz = 2;
const qux = 3;
}