Invalid variable usage JS-0043
Anti-pattern
Critical
11 days ago
—
11 days old
'query' used outside of binding context
87 if (companyRow) client.company = companyRow.id;
88 }
89 var query = Client.findOneAndUpdate({ _id: clientId }, client);
90 query 91 .exec()
92 .then(rows => {
93 if (rows) resolve(rows);'query' used outside of binding context
86 var companyRow = await query.exec();
87 if (companyRow) client.company = companyRow.id;
88 }
89 var query = Client.findOneAndUpdate({ _id: clientId }, client); 90 query
91 .exec()
92 .then(rows => {'query' used outside of binding context
48 if (companyRow) client.company = companyRow._id;
49 }
50 var query = new Client(client);
51 query 52 .save(company)
53 .then(row => {
54 resolve({'query' used outside of binding context
47 var companyRow = await query.exec();
48 if (companyRow) client.company = companyRow._id;
49 }
50 var query = new Client(client); 51 query
52 .save(company)
53 .then(row => {'index' used outside of binding context
284 for (var index = 0; index <= 200; index++) {
285 await request(app)
286 .post('/api/users/token')
287 .send({ username: 'admin', password: 'InvalidPassword' + index });288 }
289
290 var endTimeValidUsers = new Date() - start;
Description
Variables should be used inside of their binding context.
This helps avoid difficult bugs with variable hoisting.
It is a bad practice to use var declarations because variables declared using var can be accessed in a function-wide scope.
They can even be accessed before declaration.
In such cases, their value would be undefined because only declarations and not initializations are hoisted.
Bad Practice
function doIf() {
if (cond()) {
var build = true;
}
console.log(build);
}
function doIfElse() {
if (cond()) {
var build = true;
} else {
var build = false;
}
console.log(build)
}
Recommended
function doIf() {
let build;
if (cond()) {
build = true;
}
console.log(build);
}