Found no return statements in callbacks of array methods JS-0042
Anti-pattern
Major
11 days ago
—
11 days old
Array.prototype.map() expects a return value from arrow function
105 var promises = [];
106 promises.push(CustomField.findByIdAndDelete(fieldId).exec());
107 rows.map(row => {
108 row.details.map(detail => {109 if (
110 detail.customFields.some(
111 field => `${field.customField}` === fieldId,Array.prototype.map() expects a return value from arrow function
104 .then(rows => {
105 var promises = [];
106 promises.push(CustomField.findByIdAndDelete(fieldId).exec());
107 rows.map(row => {108 row.details.map(detail => {
109 if (
110 detail.customFields.some(
Description
Array has several methods for filtering, mapping, and folding.
If we forget to write return statement in a callback of those, it's probably a mistake.
If you don't want to use a return or don't need the returned results, consider using .forEach instead.
Bad Practice
const indexMap = myArray.reduce(function(memo, item, index) {
memo[item] = index;
}, {});
const foo = Array.from(nodes, function(node) {
if (node.tagName === "DIV") {
return true;
}
});
const bar = foo.filter(function(x) {
if (x) {
return true;
} else {
return;
}
});
Recommended
const indexMap = myArray.reduce(function(memo, item, index) {
memo[item] = index;
return memo;
}, {});
const foo = Array.from(nodes, function(node) {
if (node.tagName === "DIV") {
return true;
}
return false;
});
const bar = foo.map(node => node.getAttribute("id"));