Unused parameter in function RVV-B0012
Bug risk
3 months ago
—
5 months old
parameter 'c' seems to be unused, consider removing or renaming it as _
12
13func init() { Tunnels[api.Env] = StartEnvServer }
14
15func StartEnvServer(c agent.Config) chan net.Conn {16 var (
17 envListener = NewLys()
18 handler = middleware.LoggingMiddleware(middleware.GzipMiddleware(env.NewHandler()))parameter 'c' seems to be unused, consider removing or renaming it as _
11
12func init() { Tunnels[api.FS] = StartFileServer }
13
14func StartFileServer(c agent.Config) chan net.Conn {15 var (
16 fsListener = NewLys()
17 handler = middleware.LoggingMiddleware(http.FileServer(http.Dir("/")))parameter 'c' seems to be unused, consider removing or renaming it as _
12
13func init() { Tunnels[api.Metrics] = StartMetricsServer }
14
15func StartMetricsServer(c agent.Config) chan net.Conn {16 var (
17 metricsListener = NewLys()
18 handler = middleware.LoggingMiddleware(middleware.GzipMiddleware(exporter.NewHandler()))parameter 'c' seems to be unused, consider removing or renaming it as _
9
10func init() { Tunnels[api.Ping] = StartPingServer }
11
12func StartPingServer(c agent.Config) chan net.Conn {13 pingListener := NewLys()
14 go pingServe(pingListener)
15 return pingListener.Connsparameter 'c' seems to be unused, consider removing or renaming it as _
10
11func init() { Tunnels[api.Redir] = StartRedirectServer }
12
13func StartRedirectServer(c agent.Config) chan net.Conn {14 redirectListener := NewLys()
15 go redirectServe(redirectListener)
16 return redirectListener.Conns
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}