Use of
net/http's ListenAndServe function has no support for setting timeouts GO-S2114Use of net/http serve function that has no support for setting timeouts
21 if c.UseTLS() {
22 err = http.ServeTLS(ln, h.Handler(), c.Cert(), c.Key())
23 } else {
24 err = http.Serve(ln, h.Handler())25 }
26
27 returnUse of net/http serve function that has no support for setting timeouts
19 h := server.NewHub(c)
20
21 if c.UseTLS() {
22 err = http.ServeTLS(ln, h.Handler(), c.Cert(), c.Key())23 } else {
24 err = http.Serve(ln, h.Handler())
25 }Use of net/http serve function that has no support for setting timeouts
14 }
15 port := args[0]
16 log.Println("Listening on", port)
17 log.Println(http.Serve(listener.Listener(port), handler.Handler("/")))18 return nil
19}
Description
HTTP timeouts are necessary to expire inactive connections and failing to do so might make the application vulnerable to attacks like slowloris which work by sending data very slow, which in case of no timeout will keep the connection active eventually leading to a denial-of-service (DoS) attack.
Bad practice
package main
import (
"fmt"
"time"
"net/http"
)
func main() {
http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
fmt.Fprintf(w, "Hello, %s!", r.URL.Path[1:])
})
err := http.ListenAndServe(":1234", nil)
if err != nil {
panic(err)
}
}
Recommended
package main
import (
"fmt"
"time"
"net/http"
)
func main() {
http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
fmt.Fprintf(w, "Hello, %s!", r.URL.Path[1:])
})
server := &http.Server{
Addr: ":1234",
ReadHeaderTimeout: 3 * time.Second,
}
err := server.ListenAndServe()
if err != nil {
panic(err)
}
}