switch with single case can be rewritten as if or if-else CRT-A0014
Anti-pattern
Minor
6 months ago
—
4 years old
should rewrite switch statement to if statement
87 for looping {
88 b.Wait(func(events *Events) {
89 for evt := range *events {
90 switch evt {91 case event:
92 looping = false
93 returnshould rewrite switch statement to if statement
1557 var request []*Item
1558 t.previewBox.Wait(func(events *util.Events) {
1559 for req, value := range *events {
1560 switch req {1561 case reqPreviewEnqueue:
1562 request = value.([]*Item)
1563 }should rewrite switch statement to if statement
314 terminal.UpdateHeader(headerPadded)
315
316 case EvtSearchFin:
317 switch val := value.(type) {318 case *Merger:
319 if deferred {
320 count := val.Length()should rewrite switch statement to if statement
303 delay = false
304
305 case EvtSearchProgress:
306 switch val := value.(type) {307 case float32:
308 terminal.UpdateProgress(val)
309 }should rewrite switch statement to if statement
284
285 case EvtSearchNew:
286 var command *string
287 switch val := value.(type) {288 case searchRequest:
289 sort = val.sort
290 command = val.command
Description
switch statements with a single case can be rewritten as if-else or if.
Single case switch can be replaced by if-else as it appears to be more
readable. This does not apply to type switch.
Bad practice
switch ok {
case true:
// body
}
Recommended
if ok {
// body
}