Nested
if can be replaced with else if CRT-A0011
Anti-pattern
Major
6 months ago
—
3 years old
can replace 'else {if cond {}}' with 'else if cond {}'
564 r.clickY = []int{y}
565 }
566 r.prevDownTime = now
567 } else {568 if len(r.clickY) > 1 && r.clickY[0] == r.clickY[1] &&
569 time.Since(r.prevDownTime) < doubleClickDuration {
570 double = true
Description
A single nested if inside an else block can be replaced with an else if.
It's better to have as little nesting as possible. Hence, it's cleaner to
replace a single nested if inside an else with an else-if.
Bad practice
if cond1 {
// do something
} else {
if x := cond2; x {
// do something else
}
}
Recommended
if cond1 {
// do something
} else if x := cond2; x {
// do something else
}