Incorrectly formatted error string SCC-ST1005
Style
Minor
2 years ago
—
2 years old
error strings should not be capitalized
63 return errors.New("Match search pattern is not sure")
64 }
65 if code == "" {
66 return errors.New("Match value can not be empty can be md5 or hexadecimal string")67 }
68 if res, err := scanner.Search(code); err != nil {
69 return errerror strings should not be capitalized
60 case "hex":
61 scanner.SetMatcher(new(scan.HexMatcher))
62 default:
63 return errors.New("Match search pattern is not sure")64 }
65 if code == "" {
66 return errors.New("Match value can not be empty can be md5 or hexadecimal string")
Description
Error strings follow a set of guidelines to ensure uniformity and good composability.
Quoting Go Code Review Comments:
Error strings should not be capitalized (unless beginning with
proper nouns or acronyms) or end with punctuation, since they are
usually printed following other context. That is, use
fmt.Errorf("something bad") not fmt.Errorf("Something bad"), so
that log.Printf("Reading %s: %v", filename, err) formats without a
spurious capital letter mid-message.