Global variable is declared but not used PYL-W0602
Bug risk
Major
8 months ago
—
3 years old
Using global for 'screen_record_file_path_on_device' but no assignment is done
642 execute_adb_shell_command2(dump_cmd)
643
644 def _pull_and_delete_file_from_device():
645 global screen_record_file_path_on_device 646 print_message('Saving recording to %s' % filepath)
647 pull_cmd = 'pull %s %s' % (screen_record_file_path_on_device, filepath)
648 execute_adb_command2(pull_cmd)
Description
The variable is defined through the global statement but no assignment to this variable is done. It is recommended to remove it if not necessary.
Bad practice
def my_func():
global a
return a
Recommended
If it is a newly defined global, make sure to assign a value to it.
def my_func():
global a
a = 1 # Assign to the newly defined global value.
return a
Or if the global should be already defined, you can remove the global statement.
a = 1
def my_func():
return a # The global statement can be removed
Note: DeepSource will remove the global statement during autofix.