PYL-W0201 · Attribute defined outside `__init_

aragilar / stringtopy

Active

Attribute defined outside __init__ PYL-W0201

Anti-pattern

Minor

4 years ago — 4 years old

Attribute '_versioneer_generated_versions' defined outside __init__

1508    class cmd_sdist(_sdist):
1509        def run(self):
1510            versions = get_versions()
1511            self._versioneer_generated_versions = versions1512            # unless we update this, the command will keep using the old
1513            # version
1514            self.distribution.metadata.version = versions["version"]

Attribute 'verbose' defined outside __init__

versioneer.py

 412    cfg.versionfile_build = get(parser, "versionfile_build")
 413    cfg.tag_prefix = get(parser, "tag_prefix")
 414    cfg.parentdir_prefix = get(parser, "parentdir_prefix")
 415    cfg.verbose = get(parser, "verbose") 416    return cfg
 417
 418

Attribute 'parentdir_prefix' defined outside __init__

versioneer.py

 411    cfg.versionfile_source = get(parser, "versionfile_source")
 412    cfg.versionfile_build = get(parser, "versionfile_build")
 413    cfg.tag_prefix = get(parser, "tag_prefix")
 414    cfg.parentdir_prefix = get(parser, "parentdir_prefix") 415    cfg.verbose = get(parser, "verbose")
 416    return cfg
 417

Attribute 'tag_prefix' defined outside __init__

versioneer.py

 410    cfg.style = get(parser, "style") or ""
 411    cfg.versionfile_source = get(parser, "versionfile_source")
 412    cfg.versionfile_build = get(parser, "versionfile_build")
 413    cfg.tag_prefix = get(parser, "tag_prefix") 414    cfg.parentdir_prefix = get(parser, "parentdir_prefix")
 415    cfg.verbose = get(parser, "verbose")
 416    return cfg

Attribute 'versionfile_build' defined outside __init__

versioneer.py

 409    cfg.VCS = VCS
 410    cfg.style = get(parser, "style") or ""
 411    cfg.versionfile_source = get(parser, "versionfile_source")
 412    cfg.versionfile_build = get(parser, "versionfile_build") 413    cfg.tag_prefix = get(parser, "tag_prefix")
 414    cfg.parentdir_prefix = get(parser, "parentdir_prefix")
 415    cfg.verbose = get(parser, "verbose")

Description

Defining an instance attribute outside __init__ affects the readability of code. It is expected to find all the attributes an instance may have by reading its __init__ method. If there is a need to initialize attribute via sub-initialization methods, it is recommended to assign attributes to None in the init then call the sub-initialization methods.