Redundant else-blocks can be eliminated RVV-A0009
Anti-pattern
Major
6 months ago
—
2 years old
if block ends with a break statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
446 out.WriteString(line[:x])
447 out.WriteRune(newLine)
448 break
449 } else {450 // Write everything as is.
451 out.WriteString(lines[i])
452 }
Description
To ensure as little nesting as possible (to improve code readability), the
else blocks that can be eliminated should be removed. For example, if the if
block contains a return statement, the else block can be omitted entirely.
Bad practice
for {
if ok := f(); ok {
a := 1
continue
} else {
return "it's NOT okay!"
}
}
Recommended
for {
if ok := f(); ok {
a := 1
continue
}
return "it's NOT okay!"
}