Functions prefixed with
Get should return a value RVV-A0006
Anti-pattern
Major
6 months ago
—
2 years old
function 'getAnswers' seems to be a getter but it does not return any result
177 }
178}
179
180func getAnswers(params *editParams, issue *jira.Issue) {181 answer := struct{ Action string }{}
182 for answer.Action != cmdcommon.ActionSubmit {
183 err := survey.Ask([]*survey.Question{cmdcommon.GetNextAction()}, &answer)
Description
Typically, functions with names prefixed with Get are supposed to return a value.
Bad practice
func GetData(n int) {
fmt.Println(10 - n)
}
Recommended
func GetData(n int) int {
fmt.Println(10 - n)
return 10 - n
}