Appending to dictionary immediately following its definition PY-W0072
Anti-pattern
Major
10 months ago
—
3 years old
Appending to list immediately following its definition
83 """See if we can make a calendar plot!"""
84 sts = datetime.date(2015, 5, 4)
85 ets = datetime.date(2015, 6, 15)
86 data = {} 87 data[datetime.date(2015, 6, 6)] = {"val": "0606"}
88 data[datetime.date(2015, 5, 6)] = {"val": "0506"}
89 return calendar_plot(Appending to list immediately following its definition
66 """See if we can make a calendar plot!"""
67 sts = datetime.date(2015, 5, 4)
68 ets = datetime.date(2015, 8, 15)
69 data = {} 70 data[datetime.date(2015, 6, 6)] = {"val": "0606"}
71 data[datetime.date(2015, 5, 6)] = {"val": "0506"}
72 return calendar_plot(Appending to list immediately following its definition
49 """See if we can make a calendar plot!"""
50 sts = datetime.date(2015, 5, 4)
51 ets = datetime.date(2016, 1, 15)
52 data = {} 53 data[datetime.date(2015, 6, 6)] = {"val": "0606"}
54 data[datetime.date(2015, 5, 6)] = {"val": "0506"}
55 return calendar_plot(Appending to list immediately following its definition
32 """See if we can make a calendar plot!"""
33 sts = datetime.date(2015, 5, 4)
34 ets = datetime.date(2016, 4, 15)
35 data = {} 36 data[datetime.date(2015, 6, 6)] = {"val": "0606"}
37 data[datetime.date(2015, 5, 6)] = {"val": "0506"}
38 return calendar_plot(Appending to list immediately following its definition
14 """We like June, it is a good month, don't drop it."""
15 sts = datetime.date(2017, 5, 29)
16 ets = datetime.date(2017, 9, 30)
17 data = {} 18 data[datetime.date(2017, 6, 6)] = {"val": "0606"}
19 data[datetime.date(2017, 7, 6)] = {"val": "0506"}
20 return calendar_plot(
Description
Instead of adding items to a dictionary just after creation, it should be refactored to add those items into the dict definition itself.
Bad practice
env = {}
env['HOST'] = 'example.com'
env['PORT'] = 8080
Recommended
env = {'HOST': 'example.com', 'PORT': 8080}