Unnecessary
None provided as default PTC-W0039
Anti-pattern
Minor
10 months ago
—
3 years old
None as default value is redundant213 try1 = AWIPS_GRID.get(self.wmo[:4], None)
214 if try1:
215 return try1
216 return AWIPS_GRID_GUESS.get(self.wmo[3], None)217
218 def current_filename(self):
219 """None as default value is redundant210 """
211 Return the awips grid number based on the WMO header
212 """
213 try1 = AWIPS_GRID.get(self.wmo[:4], None)214 if try1:
215 return try1
216 return AWIPS_GRID_GUESS.get(self.wmo[3], None)
Description
It is unnecessary to provide None as the default value when the key is not present in the dictionary as get implicitly returns None.
Not preferred:
value = some_dict.get("key", None)
Preferred:
value = some_dict.get("key")