Unnecessary generator PTC-W0015
Anti-pattern
Major
10 months ago
—
3 years old
Unnecessary generator - rewrite as a dict comprehension
201 for i, col in enumerate(use_columns):
202 data[col][row[0], row[1]] = row[2 + i]
203 ds = xr.Dataset(
204 dict((key, (["y", "x"], data[key])) for key in data),205 coords={
206 "lon": (["x"], np.arange(dom["west"], dom["east"], DX)),
207 "lat": (["y"], np.arange(dom["south"], dom["north"], DY)),
Description
It is unnecessary to use list, set, dict around a generator expression to get an object of that type since there are comprehensions for these types.
Bad practice
squares = list(x**2 for x in range(1, 10))
large_numbers = set(n for n in numbers if n > 1000)
tree_counts = dict((tree, counts[tree]) for tree in trees)
Recommended
squares = [x**2 for x in range(1, 10)]
large_numbers = {n for n in numbers if n > 1000}
tree_counts = {tree: counts[tree] for tree in trees}