Bad function overloading JS-0388
Anti-pattern
Minor
5 months ago
—
5 months old
This overload and the one on line 84 can be combined into one signature taking
'confirm' | 'cancel'82const emit = defineEmits<{
83 (e: 'update:modelValue', modelValue: boolean): void
84 (e: 'confirm'): void
85 (e: 'cancel'): void86}>()
87
88This overload and the one on line 57 can be combined into one signature taking
'confirm' | 'cancel'55const emit = defineEmits<{
56 (e: 'update:modelValue', modelValue: boolean): void
57 (e: 'confirm'): void
58 (e: 'cancel'): void59}>()
60
61
Description
Warns for any two overloads that could be unified into one by using a union or an optional/rest parameter.
Bad Practice
function f(x: number): void;
function f(x: string): void;
f(): void;
f(...x: number[]): void;
Recommended
function f(x: number | string): void;
function f(x?: ...number[]): void;