Consider adding a doc comment for Login
3
4public class Login extends Card {
5
6 public Login(String cardNum) { 7 super(cardNum); 8 } 9
10 public static boolean isCardValid() throws SQLException {
11 ResultSet checkRs = SqlQuery.getResult(("SELECT id FROM clients WHERE CardNum=" + cardNum));Consider adding a doc comment for Card
7
8 protected static String pin;
9
10 public Card(String cardNum) {11 this.cardNum = cardNum;12 this.pin = "0000";13 }14
15 public static void setPin(String pin) {
16 Card.pin = pin;
Description
This constructor does not have any documentation.
Consider adding a documentation comment to explain its use.
While it may seem like the usage of a constructor is perfectly obvious, any consumers of your API may not be able to pick up on certain details.
Bad Practice
In the example below, it is difficult to understand what the arguments of this constructor for DataForwarder signify.
class DataForwarder {
public DataForwarder(int nTypes, String... values) {
// ...
}
}
Recommended
Document the constructor and provide useful information about it or its parameters as required.
/**
* Initializes a DataForwarder with a set of types to filter by, along with their names.
*
* @param nTypes - The number of types to filter by.
* @param values - The input type names to filter by.
*/
public DataForwarder(int nTypes, String... values) {
// ...
}
Exceptions
If you feel this constructor does not require documentation, you can add a skipcq comment to this constructor.