Consider adding a doc comment for StringGetSQL
32 }
33 }
34
35 public static String StringGetSQL(String query, String label) {36 String temp = null;37 try {38 Class.forName("com.mysql.cj.jdbc.Driver");39 Connection con =40 DriverManager.getConnection("jdbc:mysql://localhost:3306/atm", "root", "root");41 Statement stmt = con.createStatement();42 ResultSet rs = stmt.executeQuery(query);43 while (rs.next()) {44 temp = rs.getString(label);45 }4647 } catch (Exception e) {48 e.printStackTrace();49 }50 return temp;51 }52}
Consider adding a doc comment for UpdateData
18 }
19 }
20
21 public static void UpdateData(String query) {2223 try {24 Class.forName("com.mysql.cj.jdbc.Driver");25 Connection con =26 DriverManager.getConnection("jdbc:mysql://localhost:3306/atm", "root", "root");27 Statement stmt = con.createStatement();28 stmt.executeUpdate(query);2930 } catch (Exception e) {31 e.printStackTrace();32 }33 }34
35 public static String StringGetSQL(String query, String label) {
36 String temp = null;
Consider adding a doc comment for getResult
4import java.sql.Statement;
5
6public class SqlQuery {
7 public static ResultSet getResult(String query) { 8 9 try {10 Class.forName("com.mysql.cj.jdbc.Driver");11 Connection con =12 DriverManager.getConnection("jdbc:mysql://localhost:3306/atm", "root", "root");13 Statement stmt = con.createStatement();14 return stmt.executeQuery(query);1516 } catch (Exception e) {17 return null;18 }19 }20
21 public static void UpdateData(String query) {
22
Consider adding a doc comment for main
2import java.util.Scanner;
3
4public class Main {
5 public static void main(String[] args) throws Exception { 6 Scanner sc = new Scanner(System.in); 7 String CardNum; 8 do { 9 System.out.println("Lutfen Kart Numaranizi giriniz... ");10 CardNum = sc.next();11 Card card = new Card(CardNum);1213 } while (!Login.isCardValid());14 int attemps = -1;15 do {1617 System.out.println("Hosgeldiniz! lutfen bir pin saglayin");18 if (attemps > 3) {19 SqlQuery.UpdateData("UPDATE clients SET PIN='BLOCKED' WHERE CardNum=" + CardNum);20 System.out.println("Sifreniz bloke edilmistir lutfen musteri hizmetleri ile gorusun.. ");21 System.exit(2);22 } else {2324 System.out.println("Lutfen pininizi giriniz... ");25 String Pin = sc.next();26 Card.setPin(Pin);27 attemps++;28 }2930 } while (!Login.isPinTrue());3132 String currentID = Card.returnID();33 int checker = -1;3435 do {36 // terminal her seferinde temizlenmeli37 System.out.println(38 "Kullanibilir bakiyeniz: "39 + SqlQuery.StringGetSQL(40 "SELECT deposit FROM clients WHERE id=" + currentID, "deposit"));41 System.out.println("Lutfen yapmak istediginiz islemi seciniz. ");42 System.out.println("1: Para Cek 2: Para Yatir");43 System.out.println("3: Para Gonder 4: Borc Ode");44 System.out.println(" 0:Cikis Yap ");45 checker = sc.nextInt();46 Scanner scd = new Scanner(System.in);47 double amount;48 switch (checker) {49 case 0:50 System.out.println("Yine Bekleriz");51 break;52 case 1:53 System.out.println(54 "lutfen cekmek istediginiz tutari giriniz, bu minimum 10 en fazla 1000'dir");55 amount = scd.nextDouble();56 if (Transactions.withdraw(currentID, amount)) {57 System.out.println("para cekme basarili");58 } else {59 System.out.println("para cekme islemi basarisiz");60 }61 break;62 case 2:63 System.out.println("Lutfen yatirmak istediginiz tutari giriniz. ");64 amount = scd.nextDouble();65 if (Transactions.deposit(currentID, amount)) {66 System.out.println("para yatirma islemi basarili.");67 } else {68 System.out.println("para yatirma islemi basarisiz.");69 }70 break;71 case 3:72 System.out.println("Para gondermek istediginiz IBANI giriniz.. ");73 System.out.printf("TR ");74 String IBAN = sc.next();75 System.out.println("Gondermek istediginiz miktari giriniz.. ");76 amount = scd.nextDouble();77 if (Transactions.transfer(currentID, IBAN, amount)) {78 System.out.println("para gonderildi");79 } else System.out.println("para gonderilemedi.");80 break;81 case 4:82 System.out.printf("Borcunuz: ");83 System.out.printf(84 SqlQuery.StringGetSQL("SELECT debt FROM clients WHERE id=" + currentID, "debt"));85 System.out.printf(" lutfen odemek istediginiz tutari giriniz.. ");86 amount = scd.nextDouble();87 if (Transactions.payOffDebt(currentID, amount))88 System.out.println("borcunuz basariyla odendi");89 else System.out.println("borc odenemedi");90 break;91 default:92 System.out.println("Eksik ya da hatali bir tuslama yaptiniz lutfen tekrar deneyiniz..");93 }9495 } while (checker != 0);96 }97}
Consider adding a doc comment for isPinTrue
17 return false;
18 }
19
20 public static boolean isPinTrue() {2122 String cardsPin =23 SqlQuery.StringGetSQL("SELECT PIN FROM clients WHERE CardNum=" + cardNum, "PIN");2425 if (cardsPin.equals("BLOCKED")) {26 System.out.println("Pininiz bloke");27 System.exit(2);28 }2930 if (!(pin.length() == 4)) {31 System.out.println("Pininiz Dort Haneden Olusmalidir");32 return false;33 }34 try {35 int x = Integer.parseInt(pin);36 } catch (Exception e) {3738 System.out.println("Pin rakamlardan olusmalidir. ");39 return false;40 }41 if (!(pin.equals(cardsPin))) {42 System.out.println("sifreniz hatalidir. ");43 return false;44 }45 return true;46 }47}
Consider adding a doc comment for isCardValid
7 super(cardNum);
8 }
9
10 public static boolean isCardValid() throws SQLException {11 ResultSet checkRs = SqlQuery.getResult(("SELECT id FROM clients WHERE CardNum=" + cardNum));1213 while (checkRs.next()) {14 return true;15 }16 System.out.println("hatali bir kart numarasi girdiniz lutfen tekrar deneyiniz.. ");17 return false;18 }19
20 public static boolean isPinTrue() {
21
Consider adding a doc comment for returnID
24 return pin;
25 }
26
27 public static String returnID() throws SQLException {28 // todo:sqlden id çekilecek ve ana programa pushlanacak29 ResultSet rs = SqlQuery.getResult(("SELECT id FROM clients WHERE CardNum=" + cardNum));30 while (rs.next()) {31 return rs.getString("id");32 }33 return null;34 }35}
Description
This method does not have any documentation.
Consider adding a documentation comment to explain its use.
While it may seem like the usage of a method is perfectly obvious, any consumers of your API may not be able to pick up on certain details.
Bad Practice
This method appears to return an address string based on its name and the return type, but it is hard to say anything further about it. We neither know if the address will be formatted in a special way nor are we given any useful information regarding the returned value.
String getAddress() {
// ...
}
Recommended
Provide a detailed description of what the method does.
/**
* Returns the address in 3 line format,
* with street address on line 1, area/city on line 2
* and state and country as well as postal code on line 3.
*/
String getAddress() {
// ...
}