Exception classes must be named appropriately JAVA-W1000
Anti-pattern
Minor
a year ago
—
a year old
UnoError is an Exception but is not named appropriately
1package de.wroracer.uno.engine.error;
2
3public class UnoError extends Error { 4 public UnoError(String message) { 5 super(message); 6 } 7 8 public UnoError(String message, Throwable cause) { 9 super(message, cause);10 }1112 public UnoError(Throwable cause) {13 super(cause);14 }1516}CardNotPlayableError is an Exception but is not named appropriately
2
3import de.wroracer.uno.engine.card.Card;
4
5public class CardNotPlayableError extends UnoError {6 public CardNotPlayableError(Card play, Card current) {7 super("The card " + play + " is not playable on " + current);8 }9}
Description
This class is an exception, but its name does not end in Exception. This could be confusing to consumers of your API.
Bad Practice
class BadName extends Exception {
// ...
}
Recommended
class ActuallyAnException extends Exception {
// ...
}