Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
64 else:
65 value = "default_value"
66
67 if type(value) != str: 68 raise Exception()
69 else:
70 value = iter(value)
Description
raise causes control flow to be disrupted, as it will exit the block.
It is recommended to check other conditions using another if statement, and get rid of else statements as they are unnecessary.
Bad practice
def check_magic_generator(attribute):
magic = get_magic_number(attribute)
if magic < 0:
raise ValueError(f"{attribute} looks invalid")
elif magic > 100
raise ValueError(f"{attribute} is very magical")
else:
return magic
Recommended
def check_magic_generator(attribute):
magic = get_magic_number(attribute)
if magic < 0:
raise ValueError(f"{attribute} looks invalid")
if magic > 100
raise ValueError(f"{attribute} is very magical")
return magic