Consider merging collapsible if statements
155 processed_section_output: list[str] = []
156 for section_line in section_output:
157 package_name: str = section_line.split(" ")[1].split(".")[0]
158 if previous_package_name is not None:159 if package_name != previous_package_name:
160 processed_section_output.append("")
161 previous_package_name = package_name
Consider merging collapsible if statements
149 section_output.append("") # Empty line for black compatibility
150 section_output.append(section_comment_end)
151
152 if section != "STDLIB":153 if config.separate_top_level_packages:
154 previous_package_name: Optional[str] = None
155 processed_section_output: list[str] = []
Description
Nested if
statements can be collapsed into a single if
statement by separating their condition using and
operator.
Merging collapsible if
statements increases the code's readability.
Bad practice
if condition1:
if condition2:
dosomething()
Preferred
if condition1 and condition2:
dosomething()
Exception:
DeepSource will not raise this issue when the nested if
statements have comments in between them, as it could be explaining why the nested if
is in place.