'id' is defined but never used
63 * @async
64 * @param {Number} id
65 */
66 async delete(id){} 67}
68
69/**'id' is defined but never used
55 * @param {Number} id
56 * @throws {Error('Entity not found')}
57 */
58 async update(id){} 59
60
61 /**'data' is defined but never used
31 * @async
32 * @param {Object.object} data
33 */
34 async create(data){} 35
36 /**
37 * Finds all entities in the database'res' is defined but never used
27 }
28 }
29
30 static async validate(req, res){31
32 }
33}'req' is defined but never used
27 }
28 }
29
30 static async validate(req, res){31
32 }
33}'product' is assigned a value but never used
20
21 static async deleteProduct(req, res){
22 try {
23 const product = await productModel.delete(req.params.id)24 }
25 catch (error) {
26 res.json({msg: error.message})'res' is defined but never used
46 }
47 }
48
49 static async validate(req, res){50
51 }
52'req' is defined but never used
46 }
47 }
48
49 static async validate(req, res){50
51 }
52'order' is assigned a value but never used
39
40 static async deleteOrder(req, res){
41 try {
42 const order = await orderModel.delete(req.params.id)43 }
44 catch (error) {
45 res.json({msg: error.message})'order' is assigned a value but never used
29
30 static async checkOrder(req, res){
31 try {
32 const order = await orderModel.findOne(req.params.id)33
34 }
35 catch (error) {'order' is assigned a value but never used
19
20 static async downloadOrder(req, res){
21 try {
22 const order = await orderModel.findOne(req.params.id)23
24 }
25 catch (error) {'res' is defined but never used
72
73 }
74
75 async recover(req, res){76
77 }
78'req' is defined but never used
72
73 }
74
75 async recover(req, res){76
77 }
78
Description
Found variables that are declared but not used anywhere.
NOTE: In browser applications, DeepSource recommends the use of ESModules over regular
text/javascriptscripts. Currently, we don't support variables that are not explicitly exported, and are injected into other scripts by being included in an HTML file
Unused variables are most often the result of incomplete refactoring. They can lead to confusing code and minor performance hitches.
NOTE: If you have intentionally left a variable unused, we suggest you to prefix the variable name with a _ to prevent them from being flagged by DeepSource.
Bad Practice
// Write-only variables are not considered as used.
let y = 10;
y = 5;
// A variable that modifies only itself isn't considered used.
let z = 0;
z = z + 1;
// Unused argument
(function(x) {
return 5;
})();
// Unused recursive functions also raise this issue.
function fact(n) {
if (n < 2) return 1;
return n * fact(n - 1);
}
// When a function definition destructures an array,
// unused entries from the array also cause warnings.
function getY([x, y]) {
return y;
}
Recommended
let x = 10;
alert(x);
((arg1) => {
return arg1;
})();
let myFunc;
myFunc = (n) => {
// this is legal
if (n < 0) myFunc();
};
// this is also considered legal
console.log(declaredLater);
var declaredLater;
// Only the second argument from the descructured array is used.
function getY([, y]) {
return y;
}