Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
28 "Authorization": f"Bearer {access_token}",
29 }
30 response = requests.get(f"https://api.sidra.com/chain/data", headers=headers)
31 if response.status_code == 200:32 return response.json()
33 else:
34 return None
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
17 headers=headers,
18 json={"api_secret": self.api_secret},
19 )
20 if response.status_code == 200:21 return response.json()["access_token"]
22 else:
23 return None
Description
The use of else
or elif
becomes redundant and can be dropped if the last statement under the leading if
/ elif
block is a return
statement.
In the case of an elif
after return
, it can be written as a separate if
block.
For else
blocks after return
, the statements can be shifted out of else
. Please refer to the examples below for reference.
Refactoring the code this way can improve code-readability and make it easier to maintain.
Bad practice
def classify_number(x):
if x % 2 == 0:
return 'Even'
else:
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
elif x % 2 == 0 and x < 0:
return 'Even and Negative'
elif x % 2 != 0 and x < 0:
return 'Odd and Negative.'
else:
return 'Odd'
Preferred:
def classify_number(x):
if x % 2 == 0:
return 'Even'
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
if x % 2 == 0 and x < 0:
return 'Even and Negative'
if x % 2 != 0 and x < 0:
return 'Odd and Negative'
return 'Odd'