Class methods should utilize
this JS-0105
Anti-pattern
Minor
3 months ago
—
3 months old
Expected 'this' to be used by class method 'authenticate'
18 throw new Error('Not implemented');
19 }
20
21 public authenticate(identity: Identity, password: string): boolean {22 // Authenticate using the identity
23 throw new Error('Not implemented');
24 }Expected 'this' to be used by class method 'storeIdentity'
13 throw new Error('Not implemented');
14 }
15
16 public storeIdentity(identity: Identity): void {17 // Store the identity on the blockchain
18 throw new Error('Not implemented');
19 }Expected 'this' to be used by class method 'generateIdentity'
8 this.blockchain = new Blockchain();
9 }
10
11 public generateIdentity(): Identity {12 // Generate a new decentralized identity
13 throw new Error('Not implemented');
14 }
Description
If a class method does not use this, it can sometimes be made into a static function. If you do convert the method into a static function, instances of the class that call that particular method have to be converted to a static call as well (MyClass.callStaticMethod())
Bad Practice
class Person {
sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
const person = new Person();
person.sayHi();
Recommended
class Person {
static sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
Person.sayHi();