Redundant list comprehension can be replaced using generator PYL-R1728
Performance
Minor
5 months ago
—
5 months old
Consider using a generator instead 'max(self.q_table[new_price, demand] for demand in range(101))'
32 q_value = reward
33 if not done:
34 new_price, new_demand, new_reward = new_state
35 target_q_value = new_reward + self.discount_factor * max(36 [self.q_table[(new_price, demand)] for demand in range(101)])
37 q_value = reward + self.discount_factor * target_q_value
38 self.q_table[(price,
Description
Using a container in place of a generator for a calls that can accept both, slows down the performance. Consider using generators for all function calls which accept both containers and genertors.
Bad practice
# List comprehension is unnecessary here
set([student.name for student in student])
sum([y**2 for y in list(range(10))])
Recommended
set(student.name for student in students)
sum(y**2 for y in list(range(10)))