Void operators found JS-0098
Anti-pattern
Minor
8 months ago
—
a year old
Expected 'undefined' and instead saw 'void'
241 }, {
242 key: 'copyText',
243 value: function copyText() {
244 var succeeded = void 0;245
246 try {
247 succeeded = document.execCommand(this.action);
Description
A return; statement with nothing after it is redundant, and has no effect on the runtime behavior of a function.
This can be confusing, so it's better to disallow these redundant statements.
Bad Practice
function foo() { return; }
function foo() {
doSomething();
return;
}
function foo() {
if (condition) {
bar();
return;
} else {
baz();
}
}
function foo() {
switch (bar) {
case 1:
doSomething();
default:
doSomethingElse();
return;
}
}
Recommended
function foo() { return 5; }
function foo() {
return doSomething();
}
function foo() {
if (condition) {
bar();
return;
} else {
baz();
}
qux();
}
function foo() {
switch (bar) {
case 1:
doSomething();
return;
default:
doSomethingElse();
}
}
function foo() {
for (const foo of bar) {
return;
}
}