Unnecessary
else / elif used after return PYL-R1705
Style
Major
5 months ago
—
5 months old
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
72 )
73
74 # Check if the request was successful
75 if response.status_code == 201: 76 # If the device was integrated successfully, return True
77 return True
78 else:Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
48 )
49
50 # Check if the request was successful
51 if response.status_code == 201: 52 # If the alert was sent successfully, return True
53 return True
54 else:Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
17 response = requests.get(f"https://api.healthguard.com/devices/{device_id}/data")
18
19 # Check if the request was successful
20 if response.status_code == 200: 21 # Parse the JSON response
22 data = json.loads(response.text)
23
Description
The use of else or elif becomes redundant and can be dropped if the last statement under the leading if / elif block is a return statement.
In the case of an elif after return, it can be written as a separate if block.
For else blocks after return, the statements can be shifted out of else. Please refer to the examples below for reference.
Refactoring the code this way can improve code-readability and make it easier to maintain.
Bad practice
def classify_number(x):
if x % 2 == 0:
return 'Even'
else:
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
elif x % 2 == 0 and x < 0:
return 'Even and Negative'
elif x % 2 != 0 and x < 0:
return 'Odd and Negative.'
else:
return 'Odd'
Preferred:
def classify_number(x):
if x % 2 == 0:
return 'Even'
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
if x % 2 == 0 and x < 0:
return 'Even and Negative'
if x % 2 != 0 and x < 0:
return 'Odd and Negative'
return 'Odd'