if statement can be simplified PYL-R1703
Anti-pattern
Major
4 months ago
—
4 months old
The if statement can be replaced with 'return bool(test)'
42
43 # Check if the combined hash meets the target difficulty
44 target_difficulty = self.blockchain.target_difficulty
45 if int(combined_hash, 16) < target_difficulty:46 return True
47 else:
48 return False
Description
The highlighted if block can be refactored into a simplified statement, increasing its readability.
Bad practice
def simplifiable_if(arg, arg2):
if arg and not arg2:
var = True
else:
var = False
return var
Recommended
def simplifiable_if(arg, arg2):
var = bool(arg and not arg2)
return var