Implicit enumerate calls found PTC-W0060
Anti-pattern
Major
4 months ago
—
4 months old
Consider replacing
range(len(self.data_manager.data)) with enumerate(self.data_manager.data)28 """
29 committee_models = [self.model.copy() for _ in range(5)]
30 uncertainty_values = []
31 for i in range(len(self.data_manager.data)):32 input_data = self.data_manager.data[i]
33 committee_outputs = []
34 for committee_model in committee_models:Consider replacing
range(len(self.data_manager.data)) with enumerate(self.data_manager.data)11 Selects the top `num_samples` data points with the highest uncertainty.
12 """
13 uncertainty_values = []
14 for i in range(len(self.data_manager.data)):15 input_data = self.data_manager.data[i]
16 output_probabilities = self.model.predict(input_data)[0]
17 uncertainty_value = -np.max(np.log(output_probabilities))
Description
Using range(len(...)) is not pythonic. Python does not have not index-based loops. Instead, it uses collection iterators.
Python has a built-in method enumerate which adds a counter to an iterable.
Using this, you can access the counter and the value from the iterable at the same time.
It is therefore recommended to replace range(len(...)) with enumerate(...).
Not Preferred:
for index in range(len(mylist)):
...
Preferred:
for index, element in enumerate(mylist):
...